[libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra semicolons
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Oct 20 09:44:05 CEST 2020
Hi Hiro-san,
Thank you for the patch.
On Tue, Oct 20, 2020 at 02:29:02PM +0900, Hirokazu Honda wrote:
> REGISTER_PIPELINE_HANDLER macro is used with the end semicolon
> everywhere. This removes the end semicolon within the macro.
>
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
> ---
> include/libcamera/internal/pipeline_handler.h | 2 +-
> include/libcamera/span.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
> index a4e1b52..818a36a 100644
> --- a/include/libcamera/internal/pipeline_handler.h
> +++ b/include/libcamera/internal/pipeline_handler.h
> @@ -145,7 +145,7 @@ private: \
> return new handler(manager); \
> } \
> }; \
> -static handler##Factory global_##handler##Factory;
> +static handler##Factory global_##handler##Factory
In most cases we include the semicolon inside the macro
(LOG_DECLARE_CATEGORY for instance). For consistency, wouldn't it be
better to keep it here, and remove it from pipeline handlers where the
macro is used ?
>
> } /* namespace libcamera */
>
> diff --git a/include/libcamera/span.h b/include/libcamera/span.h
> index a53a80b..c0e4399 100644
> --- a/include/libcamera/span.h
> +++ b/include/libcamera/span.h
> @@ -407,6 +407,6 @@ private:
> size_type size_;
> };
>
> -}; /* namespace libcamera */
> +} /* namespace libcamera */
>
> #endif /* __LIBCAMERA_SPAN_H__ */
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list