[libcamera-devel] [PATCH 6/8] libcamera: Omit extra semicolons

[Laurent Pinchart]

Hi Hiro-san,

Thank you for the patch.

On Tue, Oct 20, 2020 at 02:29:03PM +0900, Hirokazu Honda wrote:
> The end semicolons with LOG_DEFINE_CATEGORY and
> LOG_DECLARE_CATEGORY are unnecessary.
> 
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/byte_stream_buffer.cpp                  | 2 +-
>  src/libcamera/camera_sensor.cpp                       | 2 +-
>  src/libcamera/file.cpp                                | 2 +-
>  src/libcamera/pipeline/ipu3/ipu3.cpp                  | 2 +-
>  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-
>  src/libcamera/pipeline/simple/converter.cpp           | 2 +-
>  src/libcamera/sysfs.cpp                               | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp
> index df7029b..7db5501 100644
> --- a/src/libcamera/byte_stream_buffer.cpp
> +++ b/src/libcamera/byte_stream_buffer.cpp
> @@ -14,7 +14,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DEFINE_CATEGORY(Serialization);
> +LOG_DEFINE_CATEGORY(Serialization)
>  
>  /**
>   * \file byte_stream_buffer.h
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index 78c7cee..935de52 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -28,7 +28,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DEFINE_CATEGORY(CameraSensor);
> +LOG_DEFINE_CATEGORY(CameraSensor)
>  
>  /**
>   * \struct CameraSensorInfo
> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp
> index 04b0cb6..3a3f5bb 100644
> --- a/src/libcamera/file.cpp
> +++ b/src/libcamera/file.cpp
> @@ -23,7 +23,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DEFINE_CATEGORY(File);
> +LOG_DEFINE_CATEGORY(File)
>  
>  /**
>   * \class File
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index f5a20d3..92c65d0 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -66,7 +66,7 @@ public:
>  
>  	Status validate() override;
>  
> -	const StreamConfiguration &cio2Format() const { return cio2Configuration_; };
> +	const StreamConfiguration &cio2Format() const { return cio2Configuration_; }
>  	const ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }
>  
>  private:
> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> index 0572acc..62605c0 100644
> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> @@ -17,7 +17,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DEFINE_CATEGORY(RPI_S_W);
> +LOG_DEFINE_CATEGORY(RPI_S_W)
>  
>  namespace RPi {
>  
> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp
> index 75fb297..b4ee021 100644
> --- a/src/libcamera/pipeline/simple/converter.cpp
> +++ b/src/libcamera/pipeline/simple/converter.cpp
> @@ -21,7 +21,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DECLARE_CATEGORY(SimplePipeline);
> +LOG_DECLARE_CATEGORY(SimplePipeline)
>  
>  SimpleConverter::SimpleConverter(MediaDevice *media)
>  	: m2m_(nullptr)
> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp
> index 6c8e955..3ebe66f 100644
> --- a/src/libcamera/sysfs.cpp
> +++ b/src/libcamera/sysfs.cpp
> @@ -22,7 +22,7 @@
>  
>  namespace libcamera {
>  
> -LOG_DEFINE_CATEGORY(SysFs);
> +LOG_DEFINE_CATEGORY(SysFs)
>  
>  namespace sysfs {
>  

-- 
Regards,

Laurent Pinchart