[libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for clang

[Hirokazu Honda]

Thanks Kieran and Niklas for reviewing.
Thanks Laurent for pushing the series to master.


On Tue, Oct 20, 2020 at 7:07 PM Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Hi Hiro,
>
> On 20/10/2020 10:15, Hirokazu Honda wrote:
> > The option, -Wextra-semi, helps developers to find unnecessary
> > semicolons. This option is available with clang.
> >
> > Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> So I only actually had comments on 6/8.
>
> For this and all other patches in this series:
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > ---
> >  meson.build | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index de15cc1..b0c17d3 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -64,6 +64,10 @@ if cc.get_id() == 'clang'
> >              '-stdlib=libc++',
> >          ]
> >      endif
> > +
> > +    cpp_arguments += [
> > +        '-Wextra-semi',
> > +    ]
> >  endif
> >
> >  if cc.get_id() == 'gcc'
> >
>
> --
> Regards
> --
> Kieran