[libcamera-devel] [PATCH v4 07/15] android: camera_device: Use existing variable definitions

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Oct 21 17:41:40 CEST 2020


Prevent variable shadowing by removing the redeclaration of variables
with the same name (and type) where the existing variable can be reused.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index e9404c2f3004..5272b9ecded7 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -1316,7 +1316,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
 	 * the Android camera3_stream_t.
 	 */
 	for (CameraStream &cameraStream : streams_) {
-		int ret = cameraStream.configure();
+		ret = cameraStream.configure();
 		if (ret) {
 			LOG(HAL, Error) << "Failed to configure camera stream";
 			return ret;
-- 
2.25.1



More information about the libcamera-devel mailing list