[libcamera-devel] [PATCH v3 08/14] libcamera: control_ids: Remove max values in enumerations

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Wed, Oct 21, 2020 at 04:36:29PM +0200, Jacopo Mondi wrote:
> The libcamera control definition schema includes a placeholder
> maximum value for each enumeration of supported values.
> 
> As it is now possible to create ControlInfo from the list of enumerated
> values, it is not necessary to generate the placeholder value anymore.

Very nice :-)

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/control_ids.yaml | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 2fca88e36635..637fbace152e 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -48,9 +48,6 @@ controls:
>          - name: MeteringCustom
>            value: 3
>            description: Custom metering mode.
> -        - name: MeteringModeMax
> -          value: 3
> -          description: Maximum allowed value (place any new values above here).
>  
>    # AeConstraintMode needs further attention:
>    # - Auto-generate max enum value.
> @@ -85,9 +82,6 @@ controls:
>          - name: ConstraintCustom
>            value: 3
>            description: Custom constraint mode.
> -        - name: ConstraintModeMax
> -          value: 3
> -          description: Maximum allowed value (place any new values above here).
>  
>    # AeExposureMode needs further attention:
>    # - Auto-generate max enum value.
> @@ -112,9 +106,6 @@ controls:
>          - name: ExposureCustom
>            value: 3
>            description: Custom exposure mode.
> -        - name: ExposureModeMax
> -          value: 3
> -          description: Maximum allowed value (place any new values above here).
>  
>    - ExposureValue:
>        type: float
> @@ -204,9 +195,6 @@ controls:
>          - name: AwbCustom
>            value: 7
>            description: Custom AWB mode.
> -        - name: AwbModeMax
> -          value: 7
> -          description: Maximum allowed value (place any new values above here).
>  
>    - AwbLocked:
>        type: bool

-- 
Regards,

Laurent Pinchart