[libcamera-devel] [PATCH v5 2/5] libcamera: Add SensorCropMaximum property

[Laurent Pinchart]

Hi David,

Thank you for the patch.

On Fri, Oct 23, 2020 at 11:21:56AM +0100, David Plowman wrote:
> The SensorCropMaximum camera property reports the location of that
> part of the image sensor array that is scaled to produce the output

s/is scaled/can be scaled/ as the SensorCrop control will select which
part is actually scaled ?

> images, given in native sensor pixels. It will normally change when a
> new camera mode is selected, and can be used to implement digital
> zoom.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/libcamera/property_ids.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 7261263a..a306a422 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -663,4 +663,18 @@ controls:
>          \todo Rename this property to ActiveAreas once we will have property
>                categories (i.e. Properties::PixelArray::ActiveAreas)
>  
> +  - ScalerCropMaximum:
> +      type: Rectangle
> +      description: |
> +        The maximum valid rectangle for the controls::ScalerCrop control. This
> +        reflects the minimum mandatory cropping applied in the camera sensor and
> +        the rest of the pipeline.
> +
> +        This property is valid only after the camera has been successfully
> +        configured and its value changes whenever a new configuration is

s/changes/may change/

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +        applied.
> +
> +        \todo Turn this property into a "maximum control value" for the
> +        ScalerCrop control once "dynamic" controls have been implemented.
> +
>  ...

-- 
Regards,

Laurent Pinchart