[libcamera-devel] [PATCH v5 3/5] libcamera: raspberrypi: Initialise the SensorCropMaximum property

[Laurent Pinchart]

Hi David,

Thank you for the patch.

On Fri, Oct 23, 2020 at 11:21:57AM +0100, David Plowman wrote:
> Initialise it to show we support its use, however, set it to all
> zeroes to indicate that it's not meaningful yet.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index dd62dfc7..763451a8 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -926,6 +926,13 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)
>  	/* Initialize the camera properties. */
>  	data->properties_ = data->sensor_->properties();
>  
> +	/*
> +	 * Set a default value for the ScalerCropMaximum property to show
> +	 * that we support its use, however, initialise it to zero because
> +	 * it's not meaningful until a camera mode has been chosen.
> +	 */
> +	data->properties_.set(properties::ScalerCropMaximum, Rectangle{});

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +
>  	/*
>  	 * We cache three things about the sensor in relation to transforms
>  	 * (meaning horizontal and vertical flips).

-- 
Regards,

Laurent Pinchart