[libcamera-devel] [PATCH v5 07/14] libcamera: controls: Fix rogue whitespace

Jacopo Mondi jacopo at jmondi.org
Mon Oct 26 09:50:56 CET 2020


Hello,

On Mon, Oct 26, 2020 at 01:01:27AM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Sun, Oct 25, 2020 at 05:04:27PM +0100, Jacopo Mondi wrote:
> > Remove an extra whitespace in the declaration of a vocabulary entry in
>
> Did you mean s/vocabulary/dictionary/ ?

Indeed :)

>
> > gen-controls.py script.
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> > ---
> >  utils/gen-controls.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/utils/gen-controls.py b/utils/gen-controls.py
> > index 8bdaf4bdf078..12a32eaaeee9 100755
> > --- a/utils/gen-controls.py
> > +++ b/utils/gen-controls.py
> > @@ -77,7 +77,7 @@ ${description}
> >              num_entries = 0
> >              for entry in enum:
> >                  value_info = {
> > -                    'name' : name,
> > +                    'name': name,
> >                      'value': entry['name'],
> >                      'description': format_description(entry['description']),
> >                  }
>
> --
> Regards,
>
> Laurent Pinchart


More information about the libcamera-devel mailing list