[libcamera-devel] [PATCH v6 0/6] Digital zoom

[Laurent Pinchart]

Hi David,

On Mon, Oct 26, 2020 at 05:19:02PM +0000, David Plowman wrote:
> Hi everyone
> 
> Thanks for all the reviews and comments. I believe I've got all those
> suggestions into this latest version of the patch set now. The main
> changes are:
> 
> 1, 2, and 3. No or very minor changes.
> 
> 4. The Point class has acquired operator==/operator!= and toString
> methods, mainly to support the new unit tests, but they seem like a
> reasonable thing anyway.
> 
> 5. The scalerCrop_ that we report in metadata is updated only when it
> changes.
> 
> 6. An additional patch that provides some unit tests for those
> geometry helper functions.
> 
> Hope that's all clear!

Very ! Thank you for your work.

I've reviewed the patches, I only have a handful of tiny comments that
I'll address when applying. There's one of them, though, in patch 5/6,
for which I'd like you to confirm if the proposed change is fine.

Looks like we won't need a v7 :-)

> David Plowman (6):
>   libcamera: Add ScalerCrop control
>   libcamera: Add SensorCropMaximum property
>   libcamera: raspberrypi: Initialise the SensorCropMaximum property
>   libcamera: Add geometry helper functions
>   libcamera: pipeline: raspberrypi: Implementation of digital zoom
>   test: geometry: Add unit tests for new geometry helper functions
> 
>  include/libcamera/geometry.h                  |  67 ++++
>  include/libcamera/ipa/raspberrypi.h           |   1 +
>  src/ipa/raspberrypi/raspberrypi.cpp           |   5 +
>  src/libcamera/control_ids.yaml                |  13 +
>  src/libcamera/geometry.cpp                    | 328 ++++++++++++++++++
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  99 +++++-
>  src/libcamera/property_ids.yaml               |  15 +
>  test/geometry.cpp                             | 258 +++++++++++++-
>  8 files changed, 765 insertions(+), 21 deletions(-)
> 

-- 
Regards,

Laurent Pinchart