[libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license for post_processor_jpeg.cpp

Umang Jain email at uajain.com
Fri Oct 30 04:22:07 CET 2020


Hi Laurent,

On 10/30/20 7:11 AM, Laurent Pinchart wrote:
> The JPEG post-processor is marked as licensed under GPL-2.0-or-later.
> This is an oversight and unvoluntary. License it under the
> LGPL-2.1-or-later as the rest of the camera HAL implementation.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Oops!

Acked-by: Umang Jain <email at uajain.com>

> ---
>   src/android/jpeg/post_processor_jpeg.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Umang, Hiro-san, as you've both authored commits that touch this file,
> could you please explicitly reply with an Acked-by ?
>
> This is the second time this happens, I think we need a check in either
> checkstyle.py or in the git pre-push hook.
I think checking the license would indeed would be a good candidate for 
checkstyle.py.
>
> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp
> index b9b9dc0042c9..436a50f85664 100644
> --- a/src/android/jpeg/post_processor_jpeg.cpp
> +++ b/src/android/jpeg/post_processor_jpeg.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>   /*
>    * Copyright (C) 2020, Google Inc.
>    *



More information about the libcamera-devel mailing list