[libcamera-devel] [PATCH] libcamera: pipelines: Print enabled pipelines

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tue, Sep 01, 2020 at 03:07:52PM +0100, Kieran Bingham wrote:
> Report the enabled pipelines when configuring the meson build hierarchy.
> 
> This helps clarify what pipelines are used when building, and is useful
> when looking back through build-traces to see what was actually
> configured.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> 
> This helps report enabled pipelines with the following examples visible
> during configuration phase:
> 
> ...
> Configuring version.h using configuration
> Dependency libjpeg found: YES 2.0.3 (cached)
> Program openssl found: YES (/usr/bin/openssl)
> Message: Enabling pipeline: ipu3
> Message: Enabling pipeline: raspberrypi
> Message: Enabling pipeline: rkisp1
> Message: Enabling pipeline: simple
> Message: Enabling pipeline: uvcvideo
> Message: Enabling pipeline: vimc

Should we print this on a single line ? It would prepare for using
summary() (https://mesonbuild.com/Reference-manual.html#summary), which
is available in meson 0.53 and newer.

Speaking of meson version, the latest Ubuntu LTS ships meson 0.53.2, and
Debian stable backports are currently at 0.52.1. We could upgrade to
0.52 (or 0.51 if we want to support Ubuntu 19.10), which gives us the
ability to check for Python modules. Worth it ?

> Library atomic found: YES
> Library dl found: YES
> ...
> 
>  src/libcamera/pipeline/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build
> index 46424493aa37..9eb66af59d79 100644
> --- a/src/libcamera/pipeline/meson.build
> +++ b/src/libcamera/pipeline/meson.build
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: CC0-1.0
>  
>  foreach pipeline : get_option('pipelines')
> +    message('Enabling pipeline: ' + pipeline)
>      subdir(pipeline)
>  endforeach

-- 
Regards,

Laurent Pinchart