[libcamera-devel] [PATCH] libcamera: buffer: Fix MappedBuffer::maps_ documentation

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Sep 2 15:00:43 CEST 2020


Hi Umang,

On 02/09/2020 13:57, Umang Jain wrote:
> Complete the brief for MappedBuffer::maps_ documentation.
> 
> Fixes: b3383da79f1d ("libcamera: buffer: Create a MappedBuffer")

Ooops... /o\

> Signed-off-by: Umang Jain <email at uajain.com>
> ---
>  src/libcamera/buffer.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp
> index a094737..03f628e 100644
> --- a/src/libcamera/buffer.cpp
> +++ b/src/libcamera/buffer.cpp
> @@ -392,7 +392,7 @@ MappedBuffer::~MappedBuffer()
>  
>  /**
>   * \var MappedBuffer::maps_
> - * \brief Stores the internal
> + * \brief Stores the internal mapped planes

Though maybe we don't need the word 'internal' there .. but either way.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>   *
>   * MappedBuffer derived classes shall store the mappings they create in this
>   * vector which is parsed during destruct to unmap any memory mappings which
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list