[libcamera-devel] [RFC 0/7] android: camera_device: Turn CameraStream into a class

Jacopo Mondi jacopo at jmondi.org
Wed Sep 2 15:08:39 CEST 2020


RFC based on the just sent out
"[PATCH 0/5] android: camera_device: List JPEG/RAW correct resolutions" series.

There are no functional changes in these patches (except for 1/7]), but the end
goal is to make CameraStream a class which provides a read-only interface and
enforce the creation of CameraStream instances only when all the requested
information (size, format and associated libcamera::StreamConfiguration index)
are available.

In the hope this paves ahead to ease introducing more HAL-only streams by
making the CameraStream class the intermediate representation of an Android
stream mapped to a libcamera stream.

Thanks
  j

Jacopo Mondi (7):
  libcamera: camera_configuration: Return config index
  android: camera_device: Get rid of stream counter
  android: camera_device: Check correct stream format
  android: camera_device: Use Android format
  android: camera_device: Rework CameraStream handling
  android: camera_device: Set Encoder at construction
  android: camera_device: Make CameraStream a class

 include/libcamera/camera.h    |  2 +-
 src/android/camera_device.cpp | 95 +++++++++++++++++------------------
 src/android/camera_device.h   | 23 ++++++---
 src/libcamera/camera.cpp      |  5 +-
 4 files changed, 66 insertions(+), 59 deletions(-)

--
2.28.0



More information about the libcamera-devel mailing list