[libcamera-devel] [PATCH v2] meson: Provide build configuration summary

[Kieran Bingham]

Hi Laurent,

On 04/09/2020 13:35, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Fri, Sep 04, 2020 at 12:17:02PM +0100, Kieran Bingham wrote:
>> Report the enabled pipelines when configuring the meson build hierarchy.
>>
>> This helps clarify what pipelines are used when building, and is useful
>> when looking back through build-traces to see what was actually
>> configured.
>>
>> This can be expanded upon to report other options, and ideally will be
>> replaced by mesons summary() functionality when it is available.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>> ---
>>
>> I've marked this as v2, as it superceedes the earlier "libcamera:
>> pipelines: Print enabled pipelines".
>>
>> This now produces the following output:
>>
>> ...
>> Program sphinx-build-3 found: NO
>> Program sphinx-build found: YES (/home/kbingham/.local/bin/sphinx-build)
>> Configuring config.h using configuration
>> Message: Enabled pipelines: ipu3, raspberrypi, rkisp1, simple, uvcvideo, vimc
>> Build targets in project: 86
>>
>>  meson.build | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meson.build b/meson.build
>> index b6c99ba8e0eb..b3b30327a97c 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -141,3 +141,6 @@ pkg_mod.generate(libraries : libcamera,
>>                   filebase : 'camera',
>>                   description : 'Complex Camera Support Library',
>>                   subdirs : 'libcamera')
>> +
>> +## Summarise Configurations
>> +message('Enabled pipelines: ' +  ', '.join(get_option('pipelines')) )
> 
> s/+  /+ / and s/ )$/)/

Ugh ;-) Thanks.


> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 

-- 
Regards
--
Kieran