[libcamera-devel] [PATCH v3 03/11] android: camera_device: Add debug to stream initialization
Jacopo Mondi
jacopo at jmondi.org
Tue Sep 8 15:41:34 CEST 2020
Add debug printouts to the CameraDevice::initializeStreamConfigurations()
function that help to follow the process of building the stream
configurations map.
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
src/android/camera_device.cpp | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 1b2e12d6d33c..17b5fd5f59eb 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -363,12 +363,19 @@ int CameraDevice::initializeStreamConfigurations()
const std::vector<PixelFormat> &libcameraFormats =
camera3Format.libcameraFormats;
+ LOG(HAL, Debug) << "Trying to map Android format "
+ << camera3Format.name;
+
/*
* JPEG is always supported, either produced directly by the
* camera, or encoded in the HAL.
*/
if (androidFormat == HAL_PIXEL_FORMAT_BLOB) {
formatsMap_[androidFormat] = formats::MJPEG;
+ LOG(HAL, Debug) << "Mapped Android format "
+ << camera3Format.name << " to "
+ << formats::MJPEG.toString()
+ << " (fixed mapping)";
continue;
}
@@ -379,6 +386,8 @@ int CameraDevice::initializeStreamConfigurations()
PixelFormat mappedFormat;
for (const PixelFormat &pixelFormat : libcameraFormats) {
+ LOG(HAL, Debug) << "Testing " << pixelFormat.toString();
+
/*
* The stream configuration size can be adjusted,
* not the pixel format.
@@ -414,14 +423,26 @@ int CameraDevice::initializeStreamConfigurations()
* stream configurations map, by testing the image resolutions.
*/
formatsMap_[androidFormat] = mappedFormat;
+ LOG(HAL, Debug) << "Mapped Android format "
+ << camera3Format.name << " to "
+ << mappedFormat.toString();
for (const Size &res : cameraResolutions) {
cfg.pixelFormat = mappedFormat;
cfg.size = res;
+ std::stringstream ss;
+ ss << "Testing " << cfg.toString();
+
CameraConfiguration::Status status = cameraConfig->validate();
- if (status != CameraConfiguration::Valid)
+ if (status != CameraConfiguration::Valid) {
+ ss << " not supported";
+ LOG(HAL, Debug) << ss.str();
continue;
+ }
+
+ ss << " supported";
+ LOG(HAL, Debug) << ss.str();
streamConfigurations_.push_back({ res, androidFormat });
--
2.28.0
More information about the libcamera-devel
mailing list