[libcamera-devel] [RFC 2/6] libcamera: property_ids: Define draft properties

[Niklas Söderlund]

Hi Jacopo,

Thanks for your work.

On 2020-09-11 18:20:35 +0200, Jacopo Mondi wrote:
> Libcamera is in the process of defining its own set of properties, to
> advertise the camera capabilities.
> 
> To temporary close the gap in the Android camera HAL and support all
> static metadata required in the LIMITED hw level, define a set of Draft
> properties whose values are taken from their Android definition, in order
> to allow pipeline handlers to support Android.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/property_ids.yaml | 70 +++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 74ad0195d631..62bed9f3844d 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -640,4 +640,74 @@ controls:
>          \todo Rename this property to ActiveAreas once we will have property
>                categories (i.e. Properties::PixelArray::ActiveAreas)
>  
> +  - DraftAvailableNoiseReductionModes:
> +      type: int32_t
> +      size: [n]
> +      description: |
> +        Draft property to report the list of supported noise reduction modes.
> +        Currently identical to
> +        ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES.
> +      enum:
> +        - name: DRAFT_NOISE_REDUCTION_MODE_OFF
> +          value: 0
> +          description: No noise reduction is applied
> +        - name: DRAFT_NOISE_REDUCTION_MODE_FAST
> +          value: 1
> +          description: |
> +            Noise reduction is applied without reducing the frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_HIGH_QUALITY
> +          value: 2
> +          description: |
> +            High quality noise reduction at the expense of frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_MINIMAL
> +          value: 3
> +          description: |
> +            Minimal noise reduction is applied without reducing the frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_ZSL
> +          value: 4
> +          description: |
> +            Noise reduction is applied at different levels to different streams.
> +
> +  - DraftAvailableColorCorrectionAberrationModes:
> +      type: int32_t
> +      size: [n]
> +      description: |
> +        Draft property to report the list of supported color correction
> +        aberration modes. Currently identical to
> +        ANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES.
> +      enum:
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_OFF
> +          value: 0
> +          description: No aberration correction is applied.
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_FAST
> +          value: 1
> +          description: Aberration correction will not slow down the frame rate.
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_HIGH_QUALITY
> +          value: 2
> +          description: |
> +            High quality aberration correction which might reduce the frame
> +            rate.
> +
> +  - DraftAvailableLensShadingMapModes:
> +      type: int32_t
> +      size: [n]
> +      description: |
> +        Draft property to report the list of supported lens shading map modes.
> +        Currently identical to
> +        ANDROID_STATISTICS_INFO_AVAILABLE_LENS_SHADING_MAP_MODES.
> +      enum:
> +        - name: DRAFT_LENS_SHADING_MAP_MODE_OFF
> +          value: 0
> +          description: No lens shading map mode is available.
> +        - name: DRAFT_LENS_SHADING_MAP_MODE_ON
> +          value: 1
> +          description: The lens shading map mode is available.
> +
> +  - DraftPipelineMaxDepth:
> +      type: int32_t
> +      description: |
> +        Draft control to report the maximum number of pipeline stages a frame
> +        has to go through from when it is exposed to when it is available to
> +        applications. Currently identical to ANDROID_REQUEST_PIPELINE_MAX_DEPTH.
> +
>  ...
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund