[libcamera-devel] [RFC 3/6] libcamera: control_ids: Define draft controls

Niklas Söderlund niklas.soderlund at ragnatech.se
Sun Sep 13 13:36:37 CEST 2020


Hi Jacopo,

Thanks for this massive patch :-)

On 2020-09-11 18:20:36 +0200, Jacopo Mondi wrote:
> Libcamera is in the process of defining its own set of controls
> to enable applications to control the image capture process and
> return information on the captured frames.
> 
> To temporary close the gap in the Android camera HAL and support all
> controls required in the LIMITED hw level, define a set of Draft
> controls whose values are taken from their Android definition, in order
> to allow pipeline handlers to support Android.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/control_ids.yaml | 253 +++++++++++++++++++++++++++++++++
>  1 file changed, 253 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 4c415545dcae..6d4655349241 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -284,4 +284,257 @@ controls:
>          order in an array of 9 floating point values.
>  
>        size: [3x3]
> +
> +  - DraftAePrecaptureTrigger:
> +      type: int32_t
> +      description: |
> +        Draft control for AE metering trigger. Currently identical to
> +        ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER.
> +
> +        Whether the camera device will trigger a precapture metering sequence
> +        when it processes this request.
> +      enum:
> +        - name: DRAFT_AE_PRECAPTURE_TRIGGER_IDLE
> +          value: 0
> +          description: The trigger is idle.
> +        - name: DRAFT_AE_PRECAPTURE_TRIGGER_START
> +          value: 1
> +          description: The pre-capture AE metering is started by the camera.
> +        - name: DRAFT_AE_PRECAPTURE_TRIGGER_CANCEL
> +          value: 2
> +          description: |
> +            The camera will cancel any active or completed metering sequence.
> +            The AE algorithm is reset to its initial state.
> +
> +  - DraftAfTrigger:
> +      type: int32_t
> +      description: |
> +        Draft control for AF trigger. Currently identical to
> +        ANDROID_CONTROL_AF_TRIGGER.
> +
> +        Whether the camera device will trigger autofocus for this request.
> +      enum:
> +        - name: DRAFT_AF_TRIGGER_IDLE
> +          value: 0
> +          description: The trigger is idle.
> +        - name: DRAFT_AF_TRIGGER_START
> +          value: 1
> +          description: The AF routine is started by the camera.
> +        - name: DRAFT_AF_TRIGGER_CANCEL
> +          value: 2
> +          description: |
> +            The camera will cancel any active trigger and the AF routine is
> +            reset to its initial state.
> +
> +  - DraftNoiseReductionMode:
> +      type: int32_t
> +      description: |
> +        Draft control to select the noise reduction algorithm mode. Currently
> +        identical to ANDROID_NOISE_REDUCTION_MODE.
> +
> +        Mode of operation for the noise reduction algorithm.
> +
> +        \sa properties::DraftAvailableNoiseReductionModes.
> +      enum:
> +        - name: DRAFT_NOISE_REDUCTION_MODE_OFF
> +          value: 0
> +          description: No noise reduction is applied
> +        - name: DRAFT_NOISE_REDUCTION_MODE_FAST
> +          value: 1
> +          description: |
> +            Noise reduction is applied without reducing the frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_HIGH_QUALITY
> +          value: 2
> +          description: |
> +            High quality noise reduction at the expense of frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_MINIMAL
> +          value: 3
> +          description: |
> +            Minimal noise reduction is applied without reducing the frame rate.
> +        - name: DRAFT_NOISE_REDUCTION_MODE_ZSL
> +          value: 4
> +          description: |
> +            Noise reduction is applied at different levels to different streams.
> +
> +  - DraftColorCorrectionAberrationMode:
> +      type: int32_t
> +      description: |
> +        Draft control to select the color correction aberration mode. Currently
> +        identical to ANDROID_COLOR_CORRECTION_ABERRATION_MODE.
> +
> +        Mode of operation for the chromatic aberration correction algorithm.
> +
> +        \sa properties::DraftAvailableColorCorrectionAberrationModes.
> +      enum:
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_OFF
> +          value: 0
> +          description: No aberration correction is applied.
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_FAST
> +          value: 1
> +          description: Aberration correction will not slow down the frame rate.
> +        - name: DRAFT_COLOR_CORRECTION_ABERRATION_HIGH_QUALITY
> +          value: 2
> +          description: |
> +            High quality aberration correction which might reduce the frame
> +            rate.
> +
> +  - DraftAeState:
> +      type: int32_t
> +      description: |
> +        Draft control to report the current AE algorithm state. Currently
> +        identical to ANDROID_CONTROL_AE_STATE.
> +
> +        Current state of the AE algorithm.
> +      enum:
> +        - name: DRAFT_AE_STATE_INACTIVE
> +          value: 0
> +          description: The AE algorithm is inactive.
> +        - name: DRAFT_AE_STATE_SEARCHING
> +          value: 1
> +          description: The AE algorithm has not converged yet.
> +        - name: DRAFT_AE_STATE_CONVERGED
> +          value: 2
> +          description: The AE algorithm has converged.
> +        - name: DRAFT_AE_STATE_LOCKED
> +          value: 3
> +          description: The AE algorithm is locked.
> +        - name: DRAFT_AE_STATE_FLASH_REQUIRED
> +          value: 4
> +          description: The AE algorithm would need a flash for good results
> +        - name: DRAFT_AE_STATE_PRECAPTURE
> +          value: 5
> +          description: |
> +            The AE algorithm has started a pre-capture metering session.
> +            \sa DraftAePrecaptureTrigger
> +
> +  - DraftAfState:
> +      type: int32_t
> +      description: |
> +        Draft control to report the current AF algorithm state. Currently
> +        identical to ANDROID_CONTROL_AF_STATE.
> +
> +        Current state of the AF algorithm.
> +      enum:
> +        - name: DRAFT_AF_STATE_INACTIVE
> +          value: 0
> +          description: The AF algorithm is inactive.
> +        - name: DRAFT_AF_STATE_PASSIVE_SCAN
> +          value: 1
> +          description: |
> +            AF is performing a passive scan of the scene in continuous
> +            auto-focus mode.
> +        - name: DRAFT_AF_STATE_PASSIVE_FOCUSED
> +          value: 2
> +          description: |
> +            AF believes the scene is in focus, but might restart scanning.
> +        - name: DRAFT_AF_STATE_ACTIVE_SCAN
> +          value: 3
> +          description: |
> +            AF is performing a scan triggered by an AF trigger request.
> +            \sa DraftAfTrigger
> +        - name: DRAFT_AF_STATE_FOCUSED_LOCK
> +          value: 4
> +          description: |
> +            AF believes has focused correctly and has locked focus.
> +        - name: DRAFT_AF_STATE_NOT_FOCUSED_LOCK
> +          value: 5
> +          description: |
> +            AF has not been able to focus and has locked.
> +        - name: DRAFT_AF_STATE_PASSIVE_UNFOCUSED
> +          value: 6
> +          description: |
> +            AF has completed a passive scan without finding focus.
> +
> +  - DraftAwbState:
> +      type: int32_t
> +      description: |
> +        Draft control to report the current AWB algorithm state. Currently
> +        identical to ANDROID_CONTROL_AWB_STATE.
> +
> +        Current state of the AWB algorithm.
> +      enum:
> +        - name: DRAFT_AWB_STATE_INACTIVE
> +          value: 0
> +          description: The AWB algorithm is inactive.
> +        - name: DRAFT_AWB_STATE_SEARCHING
> +          value: 1
> +          description: The AWB algorithm has not converged yet.
> +        - name: DRAFT_AWB_CONVERGED
> +          value: 2
> +          description: The AWB algorithm has converged.
> +        - name: DRAFT_AWB_LOCKED
> +          value: 3
> +          description: The AWB algorithm is locked.
> +
> +  - DraftScalerCropRegion:
> +      type: Rectangle
> +      description: |
> +        Draft control to report the region of the sensor that has been read-out.
> +        Currently identical to ANDROID_SCALER_CROP_REGION.
> +
> +        The area of the sensor that has been read out, defined relatively to
> +        the active pixel array size.
> +
> +        \sa Properties::PixelArrayActiveAreas
> +
> +  - DraftSensorTimestamp:
> +      type: int64_t
> +      description: |
> +        Draft control to report the start of exposure of the first row of the
> +        captured image. Currently identical to ANDROID_SENSOR_TIMESTAMP.
> +
> +  - DraftSensorRollingShutterSkew:
> +      type: int64_t
> +      description: |
> +        Draft control to report the time between the start of exposure of the
> +        first row and the start of exposure of the last row. Currently
> +        identical to ANDROID_SENSOR_ROLLING_SHUTTER_SKEW
> +
> +  - DraftLensShadingMapMode:
> +      type: int32_t
> +      description: |
> +        Draft control to report if the lens shading map is available. Currently
> +        identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.
> +
> +        \sa properties::DraftAvailableLensShadingMapModes.
> +      enum:
> +        - name: DRAFT_LENS_SHADING_MAP_MODE_OFF
> +          value: 0
> +          description: No lens shading map mode is available.
> +        - name: DRAFT_LENS_SHADING_MAP_MODE_ON
> +          value: 1
> +          description: The lens shading map mode is available.
> +
> +  - DraftSceneFlicker:
> +      type: int32_t
> +      description: |
> +        Draft control to report the detected scene light frequency. Currently
> +        identical to ANDROID_STATISTICS_SCENE_FLICKER.
> +      enum:
> +        - name: DRAFT_SCENE_FLICKER_OFF
> +          value: 0
> +          description: No flickering detected.
> +        - name: DRAFT_SCENE_FLICKER_50HZ
> +          value: 0
> +          description: 50Hz flickering detected.
> +        - name: DRAFT_SCENE_FLICKER_60HZ
> +          value: 0
> +          description: 50Hz flickering detected.

s/50/60/

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> +
> +  - DraftPipelineDepth:
> +      type: int32_t
> +      description: |
> +        Specifies the number of pipeline stages the frame went through from when
> +        it was exposed to when the final completed result was available to the
> +        framework. Always less than or equal to DraftPipelineMaxDepth. Currently
> +        identical to ANDROID_REQUEST_PIPELINE_DEPTH.
> +
> +        The typical value for this control is 3 as a frame is first exposed,
> +        captured and then processed in a single pass through the ISP. Any
> +        additional processing step performed after the ISP pass (in example face
> +        detection, additional format conversions etc) count as an additional
> +        pipeline stage.
> +
> +        \sa properties::DraftPipelineMaxDepth
> +
>  ...
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list