[libcamera-devel] [RFC 4/6] libcamera: pipeline_handler: Initialize properties_

Niklas Söderlund niklas.soderlund at ragnatech.se
Sun Sep 13 13:39:15 CEST 2020


Hi Jacopo,

Thanks for your work.

On 2020-09-11 18:20:37 +0200, Jacopo Mondi wrote:
> Initialize the CameraData::properties_ field with the list of
> libcamera defined properties.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  include/libcamera/internal/pipeline_handler.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
> index a4e1b529c461..e579da711b33 100644
> --- a/include/libcamera/internal/pipeline_handler.h
> +++ b/include/libcamera/internal/pipeline_handler.h
> @@ -17,6 +17,7 @@
>  
>  #include <libcamera/controls.h>
>  #include <libcamera/object.h>
> +#include <libcamera/property_ids.h>
>  #include <libcamera/stream.h>
>  
>  #include "libcamera/internal/ipa_proxy.h"
> @@ -37,7 +38,7 @@ class CameraData
>  {
>  public:
>  	explicit CameraData(PipelineHandler *pipe)
> -		: pipe_(pipe)
> +		: pipe_(pipe), properties_(properties::properties)
>  	{
>  	}
>  	virtual ~CameraData() {}
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list