[libcamera-devel] [RFC 1/4] Add pybind11 submodule

[Tomi Valkeinen]

On 18/09/2020 18:33, Kieran Bingham wrote:
> Hi Tomi,
> 
> Thank you very much for your work on python bindings, this is very exciting.
> 
> 
> On 18/09/2020 16:20, Tomi Valkeinen wrote:
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at iki.fi>
> 
> I haven't had chance to go through everything yet, but for pulling in
> the pybind11 dependency, I suspect this should be handled through the
> meson dependecy/wrap framework.
> 
> 	https://mesonbuild.com/Wrap-dependency-system-manual.html
> 
> I've never used it, so I'm not quite sure how that works yet - but I
> don't think we should expect users to have to wrangle the git submodules
> themselves before starting a build.

This works too. I pushed a version using wrap (from WrapDB, 
https://wrapdb.mesonbuild.com/pybind11) and subproject to:

https://github.com/tomba/libcamera py-subproj

I'm not sure if I like it or not... I rather like it that git handles 
the subproject, and shows if it's up to date or not. I'm not sure how 
meson wraps and subprojects work with e.g. bisecting. But wrap is 
probably more mesonic way to do it.

  Tomi