[libcamera-devel] [PATCH 16/23] libcamera: IPAManager: add isolation flag to proxy creation

Niklas Söderlund niklas.soderlund at ragnatech.se
Sat Sep 19 13:49:47 CEST 2020


Hi Paul,

Thanks for your work.

On 2020-09-15 23:20:31 +0900, Paul Elder wrote:
> When the IPA proxy is created, it needs to know whether to isolate or
> not. Feed the flag at creation of the IPA proxy.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/ipa_manager.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp
> index 2d0ea242..26458153 100644
> --- a/src/libcamera/ipa_manager.cpp
> +++ b/src/libcamera/ipa_manager.cpp
> @@ -291,7 +291,8 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,
>  		return nullptr;
>  	}
>  
> -	std::unique_ptr<IPAProxy> proxy = pf->create(m);
> +	std::unique_ptr<IPAProxy> proxy =
> +		pf->create(m, !self_->isSignatureValid(m));
>  	if (!proxy->isValid()) {
>  		LOG(IPAManager, Error) << "Failed to load proxy";
>  		return nullptr;
> -- 
> 2.27.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list