[libcamera-devel] [PATCH 04/38] libcamera: process: forward-declare EventNotifier

[Laurent Pinchart]

On Thu, Sep 24, 2020 at 09:52:31AM +0900, paul.elder at ideasonboard.com wrote:
> Hi Jacopo,
> 
> On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote:
> > Hi Paul,
> > 
> > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote:
> > > EventNotifier is not included; forward-declare it to satisfy the
> > > compiler
> > >
> > 
> > Where is it needed ? I don't see it used in process.h
> 
> Line 71:
> 	void sighandler(EventNotifier *notifier);
> 
> Line 76:
> 	EventNotifier *sigEvent_;

That's only after moving ProcessManager to process.h though. You should
squash this change with 02/38.

> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > >
> > > ---
> > > New in v2
> > > ---
> > >  include/libcamera/internal/process.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h
> > > index 458a2149..254cda85 100644
> > > --- a/include/libcamera/internal/process.h
> > > +++ b/include/libcamera/internal/process.h
> > > @@ -15,6 +15,8 @@
> > >
> > >  namespace libcamera {
> > >
> > > +class EventNotifier;
> > > +
> > >  class Process final
> > >  {
> > >  public:

-- 
Regards,

Laurent Pinchart