[libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal headers to sources

paul.elder at ideasonboard.com paul.elder at ideasonboard.com
Thu Sep 24 03:36:26 CEST 2020


On Wed, Sep 23, 2020 at 03:27:24PM +0300, Laurent Pinchart wrote:
> On Wed, Sep 23, 2020 at 12:44:41PM +0200, Jacopo Mondi wrote:
> > On Tue, Sep 22, 2020 at 10:35:04PM +0900, Paul Elder wrote:
> > > Add libcamera_internal_headers to libcamera_sources.
> > 
> > For the build-system-uneducated like me: why ?
> 
> Even if I think I know the answer, I agree with Jacopo, I think it
> should be recorded in the commit message.

I guess since I've added libcamera_generated_headers to all the meson
files for the generated code, we don't actually need this patch anymore.


Paul

> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > >
> > > ---
> > > New in v2
> > > ---
> > >  src/libcamera/meson.build | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> > > index 18ea3261..27182bfc 100644
> > > --- a/src/libcamera/meson.build
> > > +++ b/src/libcamera/meson.build
> > > @@ -53,6 +53,7 @@ libcamera_sources = files([
> > >  ])
> > >
> > >  libcamera_sources += libcamera_public_headers
> > > +libcamera_sources += libcamera_internal_headers
> > >
> > >  includes = [
> > >      libcamera_includes,


More information about the libcamera-devel mailing list