[libcamera-devel] [PATCH 4/9] README: Move pkg-config to Meson section

[Laurent Pinchart]

On Wed, Sep 23, 2020 at 09:03:15PM +0100, Kieran Bingham wrote:
> On 23/09/2020 16:15, Ricardo Ribalda wrote:
> > pkg-config it is not only used to detect libudev-dev, it is used for
> > detecting gstreamer and others. So it is more correct to place it on the
> > Meson Build system section.
> 
> Hrm, I wonder what is possible to build without pkg-config.
> 
> Gstreamer is an optional component, so that doesn't matter so much - I
> wonder if even cam/qcam would link against libcamera as I bet they use
> pkg-config too underneath.
> 
> I'd be interested to know what fails without pkg-config - but I think
> it's important enough to call it required so I don't object to this.

Likewise, I don't think we need to support pkg-config being absent.

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > Signed-off-by: Ricardo Ribalda <ricardo at ribalda.com>
> > ---
> >  README.rst | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/README.rst b/README.rst
> > index 9013c1d..836750a 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -47,7 +47,7 @@ A C++ toolchain: [required]
> >  	Either {g++, clang}
> >  
> >  Meson Build system: [required]
> > -        meson (>= 0.47) ninja-build python3-yaml
> > +        meson (>= 0.47) ninja-build python3-yaml pkg-config

Maybe keeping these alphabetically sorted ?

> >  
> >          If your distribution doesn't provide a recent enough version of meson,
> >          you can install or upgrade it using pip3.
> > @@ -64,7 +64,7 @@ for IPA module signing: [required]
> >          libgnutls28-dev openssl
> >  
> >  for device hotplug enumeration: [optional]
> > -	pkg-config libudev-dev
> > +	libudev-dev
> >  
> >  for documentation: [optional]
> >  	python3-sphinx doxygen
> > 

-- 
Regards,

Laurent Pinchart