[libcamera-devel] [PATCH v2 01/11] README: Unify dependency names

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Sep 24 15:54:24 CEST 2020


Hi Ricardo,

Thank you for the patch.

On Thu, Sep 24, 2020 at 09:19:12AM +0200, Ricardo Ribalda wrote:
> All the dependencies are for libcamera, so we should move all the
> packages under this paragraph, or make a paragraph for Meson, and a
> second one for python3-yaml. I think the later is more clear.
>
> Signed-off-by: Ricardo Ribalda <ricardo at ribalda.com>
> ---
>  README.rst | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 40d4519..e756753 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -46,8 +46,8 @@ Other distributions may have differing package names:
>  A C++ toolchain: [required]
>  	Either {g++, clang}
>  
> -for libcamera: [required]
> -        meson (>= 0.47) ninja-build python3-yaml
> +Meson Build system: [required]
> +        meson (>= 0.47) ninja-build
>  
Wouldn't it be simpler to just group all the required dependencies for
the libcamera core in a single section ? Splitting them doesn't bring
that much value I think. Maybe just

for the libcamera core: [required]
        meson (>= 0.47) ninja-build python3-yaml

?

>          If your distribution doesn't provide a recent enough version of meson,
>          you can install or upgrade it using pip3.
> @@ -57,6 +57,9 @@ for libcamera: [required]
>              pip3 install --user meson
>              pip3 install --user --upgrade meson
>  
> +for generating the control definitions: [required]
> +        python3-yaml
> +
>  for device hotplug enumeration: [optional]
>  	pkg-config libudev-dev
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list