[libcamera-devel] [PATCH 06/38] utils: ipc: import mojo

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Sep 29 05:59:08 CEST 2020


Hi Paul,

Thank you for the patch.

On Tue, Sep 22, 2020 at 10:35:05PM +0900, Paul Elder wrote:
> Import mojo from Chromium repository, so that we can use it for
> generating code for the IPC mechanism. The commit from which this was
> taken is:
> a079161ec8c6907b883f9cb84fc8c4e7896cb1d0 "Add PPAPI constructs for
> sending focus object to PdfAccessibilityTree"
> 
> This tree has been pruned to remove directories that didn't have any
> necessary code:
> - mojo/* except for mojo/public
>   - mojo core, docs, and misc files
> - mojo/public/* except for mojo/public/{tools,LICENSE}
>   - language bindings for IPC, tests, and some mojo internals
> - mojo/public/tools/{fuzzers,chrome_ipc}
> - mojo/public/tools/bindings/generators
>   - code generation for other languages
> 
> No files were modified.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> 
> ---
> Changes in v2:
> - add chromium commit id, list of pruned directories, and list of
>   modified files to the changelog

Has any file been modified, with the commit message stating "no files
were modified" ? :-)

> ---
>  utils/ipc/mojo/public/LICENSE                 |   27 +
>  utils/ipc/mojo/public/tools/.style.yapf       |    6 +
>  utils/ipc/mojo/public/tools/BUILD.gn          |   18 +
>  utils/ipc/mojo/public/tools/bindings/BUILD.gn |  108 +
>  .../ipc/mojo/public/tools/bindings/README.md  |  816 +++++++
>  .../chromium_bindings_configuration.gni       |   51 +
>  .../tools/bindings/compile_typescript.py      |   27 +
>  .../tools/bindings/concatenate-files.py       |   54 +
>  ...concatenate_and_replace_closure_exports.py |   73 +
>  .../bindings/format_typemap_generator_args.py |   36 +
>  .../tools/bindings/gen_data_files_list.py     |   52 +
>  .../tools/bindings/generate_type_mappings.py  |  187 ++
>  .../ipc/mojo/public/tools/bindings/mojom.gni  | 1941 +++++++++++++++++
>  .../bindings/mojom_bindings_generator.py      |  390 ++++
>  .../mojom_bindings_generator_unittest.py      |   62 +
>  .../tools/bindings/mojom_types_downgrader.py  |  119 +
>  .../tools/bindings/validate_typemap_config.py |   57 +
>  utils/ipc/mojo/public/tools/mojom/README.md   |   14 +
>  .../mojom/check_stable_mojom_compatibility.py |  170 ++
>  ...eck_stable_mojom_compatibility_unittest.py |  260 +++
>  .../mojo/public/tools/mojom/const_unittest.py |   90 +
>  .../mojo/public/tools/mojom/enum_unittest.py  |   92 +
>  .../mojo/public/tools/mojom/mojom/BUILD.gn    |   43 +
>  .../mojo/public/tools/mojom/mojom/__init__.py |    0
>  .../mojo/public/tools/mojom/mojom/error.py    |   28 +
>  .../mojo/public/tools/mojom/mojom/fileutil.py |   45 +
>  .../tools/mojom/mojom/fileutil_unittest.py    |   40 +
>  .../tools/mojom/mojom/generate/__init__.py    |    0
>  .../mojom/mojom/generate/constant_resolver.py |   93 +
>  .../tools/mojom/mojom/generate/generator.py   |  325 +++
>  .../mojom/generate/generator_unittest.py      |   74 +
>  .../tools/mojom/mojom/generate/module.py      | 1635 ++++++++++++++
>  .../mojom/mojom/generate/module_unittest.py   |   31 +
>  .../public/tools/mojom/mojom/generate/pack.py |  258 +++
>  .../mojom/mojom/generate/pack_unittest.py     |  225 ++
>  .../mojom/mojom/generate/template_expander.py |   83 +
>  .../tools/mojom/mojom/generate/translate.py   |  854 ++++++++
>  .../mojom/generate/translate_unittest.py      |   73 +
>  .../tools/mojom/mojom/parse/__init__.py       |    0
>  .../public/tools/mojom/mojom/parse/ast.py     |  427 ++++
>  .../tools/mojom/mojom/parse/ast_unittest.py   |  121 +
>  .../mojom/mojom/parse/conditional_features.py |   82 +
>  .../parse/conditional_features_unittest.py    |  233 ++
>  .../public/tools/mojom/mojom/parse/lexer.py   |  251 +++
>  .../tools/mojom/mojom/parse/lexer_unittest.py |  198 ++
>  .../public/tools/mojom/mojom/parse/parser.py  |  488 +++++
>  .../mojom/mojom/parse/parser_unittest.py      | 1390 ++++++++++++
>  .../mojo/public/tools/mojom/mojom_parser.py   |  361 +++
>  .../tools/mojom/mojom_parser_test_case.py     |   73 +
>  .../tools/mojom/mojom_parser_unittest.py      |  171 ++
>  .../tools/mojom/stable_attribute_unittest.py  |  127 ++
>  .../mojom/version_compatibility_unittest.py   |  397 ++++
>  .../public/tools/run_all_python_unittests.py  |   28 +
>  utils/ipc/tools/diagnosis/crbug_1001171.py    |   51 +
>  54 files changed, 12855 insertions(+)
>  create mode 100644 utils/ipc/mojo/public/LICENSE
>  create mode 100644 utils/ipc/mojo/public/tools/.style.yapf
>  create mode 100644 utils/ipc/mojo/public/tools/BUILD.gn
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/BUILD.gn
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/README.md
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/chromium_bindings_configuration.gni
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/compile_typescript.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate-files.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/format_typemap_generator_args.py
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/gen_data_files_list.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/generate_type_mappings.py
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom.gni
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator.py
>  create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator_unittest.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_types_downgrader.py
>  create mode 100755 utils/ipc/mojo/public/tools/bindings/validate_typemap_config.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/README.md
>  create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility.py
>  create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/const_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/enum_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/BUILD.gn
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/__init__.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/error.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/__init__.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/constant_resolver.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/template_expander.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/__init__.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py
>  create mode 100755 utils/ipc/mojo/public/tools/mojom/mojom_parser.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_test_case.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/stable_attribute_unittest.py
>  create mode 100644 utils/ipc/mojo/public/tools/mojom/version_compatibility_unittest.py
>  create mode 100755 utils/ipc/mojo/public/tools/run_all_python_unittests.py
>  create mode 100644 utils/ipc/tools/diagnosis/crbug_1001171.py

Should BUILD.gn be dropped too ?

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

If you have to send a new version of this series, you could omit the
changes from this patch, just include the changelog, as it's fairly big
otherwise.


[snip]

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list