[libcamera-devel] [PATCH v3 0/6] Digital zoom

David Plowman david.plowman at raspberrypi.com
Tue Sep 29 18:39:54 CEST 2020


Hi everyone

Despite not originally intending to, I've actually made a version 3 of
the digital zoom patches, just to take care of a few things that might
be a bit annoying otherwise.

1. I've improved the description of the IspCrop control as was
suggested.

2. I've improved the description of the zoom option in cam (if we
decide to use this patch!), also as was proposed.

3. There was actually a problem with the "{}" syntax to denote zero
Rectangles in include/libcamera/ipa/raspberrypi.h. They were failing a
range type test in ControlInfoMap::generateIdmap() and so the control
wasn't working. I've replaced "{}" by "Rectangle{}" which seems OK.

4. There's been a bit of churn in the RPi pipeline handler lately so
rebasing gave some conflicts. I've fixed those up.

Otherwise everything else remains the same.

Thanks!
David

David Plowman (6):
  libcamera: Add SensorOutputSize property
  libcamera: Initialise the SensorOutputSize property
  libcamera: Add IspCrop control
  libcamera: Add geometry helper functions
  libcamera: pipeline: raspberrypi: Implementation of digital zoom
  cam: Add command line option to test IspCrop control

 include/libcamera/geometry.h                  |  20 +++
 include/libcamera/ipa/raspberrypi.h           |   1 +
 src/cam/capture.cpp                           |  25 +++-
 src/cam/capture.h                             |   2 +-
 src/cam/main.cpp                              |   3 +
 src/cam/main.h                                |   1 +
 src/ipa/raspberrypi/raspberrypi.cpp           |   7 +
 src/libcamera/camera_sensor.cpp               |   6 +
 src/libcamera/control_ids.yaml                |  12 ++
 src/libcamera/geometry.cpp                    | 129 ++++++++++++++++++
 .../pipeline/raspberrypi/raspberrypi.cpp      |  47 +++++++
 src/libcamera/property_ids.yaml               |  19 +++
 12 files changed, 269 insertions(+), 3 deletions(-)

-- 
2.20.1



More information about the libcamera-devel mailing list