[libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the SensorOutputSize property

[Kieran Bingham]

Hi David,

On 29/09/2020 17:39, David Plowman wrote:
> Add a default initialisation according to the sensor resolution,
> though it will need updating when the camera mode changes.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/camera_sensor.cpp | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index d2679a4b..c9a19b02 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -277,6 +277,12 @@ int CameraSensor::init()
>  	 */
>  	resolution_ = sizes_.back();
>  
> +	/*
> +	 * Set a default value for the SensorOutputSize, though it will have to
> +	 * be updated when new camera modes are chosen.
> +	 */
> +	properties_.set(properties::SensorOutputSize, resolution_);

I guess here, this is just an initialisation, but doesn't reflect what's
actually set on the sensor yet.

Should we also set this during setFormat() ?

> +
>  	return 0;
>  }
>  
> 

-- 
Regards
--
Kieran