[libcamera-devel] [PATCH v3 1/6] libcamera: Add SensorOutputSize property

[Jacopo Mondi]

Hi kieran

On Tue, Sep 29, 2020 at 09:07:08PM +0100, Kieran Bingham wrote:
> Hi David,
>
> On 29/09/2020 17:39, David Plowman wrote:
> > The SensorOutputSize camera property reports the image size that the
> > next step in processing after the sensor and CSI-2 receiver - usually
> > the ISP - will see. It will normally change when a new camera mode is
> > selected, and can be used to implement digital zoom.
> >
> > Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> > ---
> >  src/libcamera/property_ids.yaml | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > index 74ad0195..8011b88c 100644
> > --- a/src/libcamera/property_ids.yaml
> > +++ b/src/libcamera/property_ids.yaml
> > @@ -640,4 +640,23 @@ controls:
> >          \todo Rename this property to ActiveAreas once we will have property
> >                categories (i.e. Properties::PixelArray::ActiveAreas)
> >
> > +  - SensorOutputSize:
> > +      type: Size
> > +      description: |
> > +        The size, in pixels, of the image being used to produce the
> > +        desired output streams. The image size might correspond to the
> > +        size of the frames produced by the image sensor but would also
> > +        take into account additional cropping (or even re-scaling)
> > +        performed by the CSI-2 receiver to adjust the sensor frame
> > +        size to conform to the output image sizes and aspect ratios.
> > +        The property is meaningful only after the Camera has been
> > +        successfully configured and its value changes whenever a new
> > +        configuration is applied. It can be used to implement digital
> > +        zoom.
> > +
>
> I assume this is after all binning etc too, but that's part of the mode
> selection so I think that's implied.
>
> > +        \sa controls::ISPCrop
> > +
> > +        \todo Move this property to CameraConfiguration once the
> > +        feature is made available
>
> Instead of the Camera Sensor you mean ?

Instead of the Camera properties

>
> Can't see anything wrong though so...
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > +
> >  ...
> >
>
> --
> Regards
> --
> Kieran
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel