[libcamera-devel] [PATCH v4 0/9] android: camera_device: Add support for internal buffers

Jacopo Mondi jacopo at jmondi.org
Wed Sep 30 15:26:58 CEST 2020


Addressed latest comments from Laurent and Kieran.

The only missing part is to settle on the owership of the allocator and
the buffer queue management, which this series still has in the CameraDevice.

As detailed in replies to v3 and private discussions, I don't think it's worth
moving them in the CameraStream as it will undergo reworks and in the near
future, and moving allocator_ there would require marginally redesigning it.

As this series adds a missing feature and actually fixes several tests, I think
it's good to go in its current form. Although I agree we're piling a design
debt which needs to be addressed by moving CameraStream to become a first class
citizen of the HAL and not a CameraDevice internal component.

Thanks
  j

Jacopo Mondi (9):
  android: camera_device: Add CameraStream::Type
  android: camera_device: Add frame allocator
  libcamera: frame_buffer_allocator: Add freeAll()
  android: camera_device: Clear allocator
  android: camera_device: Clear streams_ in close()
  android: camera_device: Allocate buffer pools
  android: camera_device: Add methods to get and return buffers
  android: camera_device: Use libcamera buffer pool
  android: camera_device: Add stream mapping log

 include/libcamera/framebuffer_allocator.h |   1 +
 src/android/camera_device.cpp             | 166 +++++++++++++++++++---
 src/android/camera_device.h               | 102 ++++++++++++-
 src/libcamera/framebuffer_allocator.cpp   |   8 ++
 4 files changed, 254 insertions(+), 23 deletions(-)

--
2.28.0



More information about the libcamera-devel mailing list