[libcamera-devel] [RFC PATCH 6/8] android: camera_device: Add AE mode off to AE available modes

Paul Elder paul.elder at ideasonboard.com
Thu Apr 1 12:13:38 CEST 2021


Hardware level FULL requires that AE mode off is an available AE mode.
Add it.

This allows the following CTS test to pass:
- android.hardware.camera2.cts.CaptureRequestTest#testAeModeAndLock

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
 src/android/camera_device.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index fc432263..584c3c4a 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -760,7 +760,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()
 				  aeAvailableAntiBandingModes.data(),
 				  aeAvailableAntiBandingModes.size());
 
+	/* \todo FULL requires OFF */
 	std::vector<uint8_t> aeAvailableModes = {
+		ANDROID_CONTROL_AE_MODE_OFF,
 		ANDROID_CONTROL_AE_MODE_ON,
 	};
 	staticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,
-- 
2.27.0



More information about the libcamera-devel mailing list