[libcamera-devel] [PATCH v3 5/5] android: soraka: Add camera HAL configuration

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Mar 30, 2021 at 04:21:13PM +0200, Jacopo Mondi wrote:
> Add camera HAL configuration file for IPU3 Soraka.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Hirokazu Honda <hiroh at chromium.org>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/android/data/soraka/camera_hal.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 src/android/data/soraka/camera_hal.yaml
> 
> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml
> new file mode 100644
> index 000000000000..605f3096b726
> --- /dev/null
> +++ b/src/android/data/soraka/camera_hal.yaml
> @@ -0,0 +1,10 @@
> +cameras:
> +  "\\_SB_.PCI0.I2C4.CAM1":
> +    model: ov5670

I've just realized we don't use the model. Should we drop it, or do you
envision it being used in the future ?

> +    location: front
> +    rotation: 0
> +
> +  "\\_SB_.PCI0.I2C2.CAM0":
> +    model: ov13858
> +    location: back
> +    rotation: 0

-- 
Regards,

Laurent Pinchart