[libcamera-devel] [PATCH] android: mm: cros: Fix compilation

[Hirokazu Honda]

Thanks Laurent for this fix.

On Sun, Apr 4, 2021 at 8:59 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Commit 7d7879833812 ("android: mm: cros: Handle buffer registration
> failure") mistakenly tried to initialize the CameraBuffer::Private
> registered member variable instead of registered_. This reults in a
> compilation failure. Fix it.
>
> Fixes: 7d7879833812 ("android: mm: cros: Handle buffer registration failure")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/android/mm/cros_camera_buffer.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> I failed to catch this before pushing :-( Sorry. I'll push the fix right
> away to fix the compilation breakage.
>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp
> index 2a82d4b7c470..1a4fd5d1dfe3 100644
> --- a/src/android/mm/cros_camera_buffer.cpp
> +++ b/src/android/mm/cros_camera_buffer.cpp
> @@ -50,7 +50,7 @@ private:
>  CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,
>                                buffer_handle_t camera3Buffer, int flags)
>         : Extensible::Private(cameraBuffer), handle_(camera3Buffer),
> -         numPlanes_(0), valid_(false), registered(false)
> +         numPlanes_(0), valid_(false), registered_(false)
>  {
>         bufferManager_ = cros::CameraBufferManager::GetInstance();
>
> --
> Regards,
>
> Laurent Pinchart
>