[libcamera-devel] [PATCH 1/3] libcamera: pipeline: rkisp1: Stop IPA before streams

Nícolas F. R. A. Prado nfraprado at collabora.com
Tue Apr 6 20:23:33 CEST 2021


The IPA should be stopped before stopping the streams in order to avoid
a "No BufferCache available to queue" issue.

This issue happened while running lc-compliance.

Suggested-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 037573270d1e..c122c9be2afd 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -827,6 +827,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)
 
 	isp_->setFrameStartEnabled(false);
 
+	data->ipa_->stop();
+
 	selfPath_.stop();
 	mainPath_.stop();
 
@@ -840,8 +842,6 @@ void PipelineHandlerRkISP1::stop(Camera *camera)
 		LOG(RkISP1, Warning)
 			<< "Failed to stop parameters for " << camera->id();
 
-	data->ipa_->stop();
-
 	data->frameInfo_.clear();
 
 	freeBuffers(camera);
-- 
2.31.1



More information about the libcamera-devel mailing list