[libcamera-devel] [PATCH] libcamera: thread: Fix typo in comment

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Apr 7 10:56:11 CEST 2021


Hi Sebastian,

Thank you for the patch.

On Wed, Apr 07, 2021 at 07:31:40AM +0200, Sebastian Fricke wrote:
> s/This method enter/This method enters/

This duplicates the content of the patch itself, but there's really not
much else that needs to be said. In my opinion this is a valid case
where a commit message could be left empty. It doesn't matter much.

> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/thread.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp
> index f339dab1..f14c433f 100644
> --- a/src/libcamera/thread.cpp
> +++ b/src/libcamera/thread.cpp
> @@ -290,7 +290,7 @@ void Thread::startThread()
>  /**
>   * \brief Enter the event loop
>   *
> - * This method enter an event loop based on the event dispatcher instance for
> + * This method enters an event loop based on the event dispatcher instance for
>   * the thread, and blocks until the exit() method is called. It is meant to be
>   * called within the thread from the run() method and shall not be called
>   * outside of the thread.

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list