[libcamera-devel] [PATCH] libcamera: camera_manager: Remove \todo on hotplug/unplug of cameras

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Tue, Mar 16, 2021 at 11:50:04AM +0530, Umang Jain wrote:
> Fixes: e9b47217b44c ("libcamera: camera_manager: Introduce signals when a camera is added or removed")
> Signed-off-by: Umang Jain <email at uajain.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/camera_manager.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index 67641a55..8682cbcd 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -251,10 +251,6 @@ void CameraManager::Private::removeCamera(Camera *camera)
>   * action from the application. Once the application has released all the
>   * references it held to cameras, the camera manager can be stopped with
>   * stop().
> - *
> - * \todo Add interface to register a notification callback to the user to be
> - * able to inform it new cameras have been hot-plugged or cameras have been
> - * removed due to hot-unplug.
>   */
>  
>  CameraManager *CameraManager::self_ = nullptr;

-- 
Regards,

Laurent Pinchart