[libcamera-devel] [PATCH 1/3] libcamera: ipa_proxy: Scope ProxyState to IPAProxy

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Apr 13 14:25:32 CEST 2021


The ProxyState is only used by the IPAProxy, so it should remain inside
that scope.  This helps clarify the usage, and improves the
documentation by bringing the (future) ProxyState documentation into the
class.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 include/libcamera/internal/ipa_proxy.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h
index 9fe446c35f04..ea9f0760c2fc 100644
--- a/include/libcamera/internal/ipa_proxy.h
+++ b/include/libcamera/internal/ipa_proxy.h
@@ -17,15 +17,15 @@ namespace libcamera {
 
 class IPAModule;
 
-enum ProxyState {
-	ProxyStopped,
-	ProxyStopping,
-	ProxyRunning,
-};
-
 class IPAProxy : public IPAInterface
 {
 public:
+	enum ProxyState {
+		ProxyStopped,
+		ProxyStopping,
+		ProxyRunning,
+	};
+
 	IPAProxy(IPAModule *ipam);
 	~IPAProxy();
 
-- 
2.25.1



More information about the libcamera-devel mailing list