[libcamera-devel] [PATCH v2 2/2] libcamera: pipeline: raspberrypi: Update ControlInfos after sensor format change
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Apr 13 23:36:17 CEST 2021
Hi David,
On 06/04/2021 11:40, David Plowman wrote:
> The Raspberry Pi pipeline handler does not update the sensor format
> using CameraSensor::setFormat, so it must manually force the update of
> the associated ControlInfos.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index f22e286e..bbcc15ec 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -608,6 +608,12 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)
> if (ret)
> return ret;
>
> + /*
> + * The control ranges associated with the sensor may need updating
> + * after a format change.
> + */
> + data->sensor_->updateControlInfos();
> +
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> LOG(RPI, Info) << "Sensor: " << camera->id()
> << " - Selected mode: " << sensorFormat.toString();
>
>
--
Regards
--
Kieran
More information about the libcamera-devel
mailing list