[libcamera-devel] [PATCH v2 1/3] ipa: raspberrypi: Make CamHelper exposure methods virtual

[David Plowman]

I forgot to add Naush's "Reviewed-by" tag:

On Thu, 8 Apr 2021 at 14:36, David Plowman
<david.plowman at raspberrypi.com> wrote:
>
> This allows derived classes to override them if they have any special
> behaviours to implement. For instance if a particular camera mode
> produces a different signal level to other modes, you might choose to
> address that in the gain or exposure methods.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>

>
> ---
>  src/ipa/raspberrypi/cam_helper.hpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp
> index 1b2d6eec..4053a870 100644
> --- a/src/ipa/raspberrypi/cam_helper.hpp
> +++ b/src/ipa/raspberrypi/cam_helper.hpp
> @@ -66,8 +66,8 @@ public:
>         virtual ~CamHelper();
>         void SetCameraMode(const CameraMode &mode);
>         MdParser &Parser() const { return *parser_; }
> -       uint32_t ExposureLines(double exposure_us) const;
> -       double Exposure(uint32_t exposure_lines) const; // in us
> +       virtual uint32_t ExposureLines(double exposure_us) const;
> +       virtual double Exposure(uint32_t exposure_lines) const; // in us
>         virtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,
>                                       double maxFrameDuration) const;
>         virtual uint32_t GainCode(double gain) const = 0;
> --
> 2.20.1
>