[libcamera-devel] [PATCH v3 1/3] ipa: raspberrypi: Make CamHelper exposure methods virtual

[Kieran Bingham]

Hi David,

On 14/04/2021 11:29, David Plowman wrote:
> This allows derived classes to override them if they have any special
> behaviours to implement. For instance if a particular camera mode
> produces a different signal level to other modes, you might choose to
> address that in the gain or exposure methods.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> Reviewed-by: Naushir Patuck <naush at raspberrypi.com>

This isn't actually used yet is it?
But I don't see any harm in it, given that's the point of the cam helper
interface.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/cam_helper.hpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp
> index 1b2d6eec..4053a870 100644
> --- a/src/ipa/raspberrypi/cam_helper.hpp
> +++ b/src/ipa/raspberrypi/cam_helper.hpp
> @@ -66,8 +66,8 @@ public:
>  	virtual ~CamHelper();
>  	void SetCameraMode(const CameraMode &mode);
>  	MdParser &Parser() const { return *parser_; }
> -	uint32_t ExposureLines(double exposure_us) const;
> -	double Exposure(uint32_t exposure_lines) const; // in us
> +	virtual uint32_t ExposureLines(double exposure_us) const;
> +	virtual double Exposure(uint32_t exposure_lines) const; // in us
>  	virtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,
>  				      double maxFrameDuration) const;
>  	virtual uint32_t GainCode(double gain) const = 0;
> 

-- 
Regards
--
Kieran