[libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a wrong choice of term

[Laurent Pinchart]

Hi Sebastian,

Thank you for the patch.

On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote:
> Sensors provide embedded buffers and not metadata buffers, replace the
> incorrect term with the correct one.
> 
> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
> ---
>  src/ipa/raspberrypi/cam_helper.hpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp
> index eaf73019..2ab3d49f 100644
> --- a/src/ipa/raspberrypi/cam_helper.hpp
> +++ b/src/ipa/raspberrypi/cam_helper.hpp
> @@ -35,7 +35,7 @@ namespace RPiController {
>  //
>  // A method to query if the sensor outputs embedded data that can be parsed.
>  //
> -// A parser to parse the metadata buffers provided by some sensors (for
> +// A parser to parse the embedded buffers provided by some sensors (for

The correct term would be "embedded data", not just "embedded". That's a
form of metadata though. I don't mind much either way, let's say what
David prefers.

>  // example, the imx219 does; the ov5647 doesn't). This allows us to know for
>  // sure the exposure and gain of the frame we're looking at. CamHelper
>  // provides methods for converting analogue gains to and from the sensor's

-- 
Regards,

Laurent Pinchart