[libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera HAL configuration

Jacopo Mondi jacopo at jmondi.org
Thu Apr 15 15:56:51 CEST 2021


Hi Hiro, Tomasz, Han-lin

On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:
> Add camera HAL configuration file for IPU3 Soraka.
>

I've sent this patch for discussion, but I'm wondering if libcamera is
the right place where to store the HAL configuration file.

In my opinion they would be better placed in the device overlay, like
it happens today, in example, with the Intel HAL .xml configuration
files.

What do you think ? We should find a way to install this file in
/etc/libcamera/ before merging the series, otherwise we'll break the
HAL support in ChromiumOS.

Thanks
  j

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Hirokazu Honda <hiroh at chromium.org>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/android/data/soraka/camera_hal.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 src/android/data/soraka/camera_hal.yaml
>
> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml
> new file mode 100644
> index 000000000000..2e9964035098
> --- /dev/null
> +++ b/src/android/data/soraka/camera_hal.yaml
> @@ -0,0 +1,8 @@
> +cameras:
> +  "\\_SB_.PCI0.I2C4.CAM1":
> +    location: front
> +    rotation: 0
> +
> +  "\\_SB_.PCI0.I2C2.CAM0":
> +    location: back
> +    rotation: 0
> --
> 2.31.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel


More information about the libcamera-devel mailing list