[libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3: frames: Fail if the FrameInfo can't be found

[Kieran Bingham]

Hi JM,

On 20/04/2021 18:20, Jean-Michel Hautbois wrote:
> Hi Kieran,
> 
> Thanks for the patch !
> 
> On 20/04/2021 15:07, Kieran Bingham wrote:
>> The FrameInfo structure associates the data sent to the IPA
>> and is essential for handling events.
>>
>> If it can not be found, this is a fatal error which must be fixed.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>
>> ---
>> v3:
>>  - Make all occurrences of failing to find a frame info fatal.
>> ---
>>  src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp
>> index 03e8131c4829..a1b014eed8d7 100644
>> --- a/src/libcamera/pipeline/ipu3/frames.cpp
>> +++ b/src/libcamera/pipeline/ipu3/frames.cpp
>> @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)
>>  	if (itInfo != frameInfo_.end())
>>  		return itInfo->second.get();
>>  
>> -	LOG(IPU3, Error) << "Can't find tracking informaton for frame " << id;
>> +	LOG(IPU3, Fatal) << "Can't find tracking informaton for frame " << id;
> small typo here: s/informaton/information
>> +
>>  	return nullptr;
>>  }
>>  
>> @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)
>>  			return info;
>>  	}
>>  
>> -	LOG(IPU3, Error) << "Can't find tracking informaton from buffer";
>> +	LOG(IPU3, Fatal) << "Can't find tracking informaton from buffer";
>> +
> and here :-)

aha, good spot. Can't believe I missed that.
Not actually related to the change in this patch - but worth fixing up
at the same time, so I've updated the patch to include it.

Thanks


>>  	return nullptr;
>>  }
>>  
>>
> 
> With those addressed:
> Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> 

-- 
Regards
--
Kieran