[libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1: Fail RkISP1FrameInfo can't be found

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tue, Apr 20, 2021 at 02:07:38PM +0100, Kieran Bingham wrote:
> The RkISP1FrameInfo structure associated data sent to the IPA and is
> essential for handling events.
> 
> If it can not be found, this is a fatal error which must be fixed.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 549f4a4e61a8..c75666391222 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)
>  	if (itInfo != frameInfo_.end())
>  		return itInfo->second;
>  
> -	LOG(RkISP1, Error) << "Can't locate info from frame";
> +	LOG(RkISP1, Fatal) << "Can't locate info from frame";
> +
>  	return nullptr;
>  }
>  
> @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from buffer";
> +	LOG(RkISP1, Fatal) << "Can't locate info from buffer";
> +
>  	return nullptr;
>  }
>  
> @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from request";
> +	LOG(RkISP1, Fatal) << "Can't locate info from request";
> +
>  	return nullptr;
>  }
>  

-- 
Regards,

Laurent Pinchart