[libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3: frames: Fail if the FrameInfo can't be found

[Hirokazu Honda]

Hi Kieran, Thanks for the patch,

On Wed, Apr 21, 2021 at 7:19 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Apr 20, 2021 at 02:07:37PM +0100, Kieran Bingham wrote:
> > The FrameInfo structure associates the data sent to the IPA
> > and is essential for handling events.
> >
> > If it can not be found, this is a fatal error which must be fixed.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > ---
> > v3:
> >  - Make all occurrences of failing to find a frame info fatal.
> > ---
> >  src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp
> > index 03e8131c4829..a1b014eed8d7 100644
> > --- a/src/libcamera/pipeline/ipu3/frames.cpp
> > +++ b/src/libcamera/pipeline/ipu3/frames.cpp
> > @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)
> >       if (itInfo != frameInfo_.end())
> >               return itInfo->second.get();
> >
> > -     LOG(IPU3, Error) << "Can't find tracking informaton for frame " << id;
> > +     LOG(IPU3, Fatal) << "Can't find tracking informaton for frame " << id;
> > +
> >       return nullptr;
> >  }
> >
> > @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)
> >                       return info;
> >       }
> >
> > -     LOG(IPU3, Error) << "Can't find tracking informaton from buffer";
> > +     LOG(IPU3, Fatal) << "Can't find tracking informaton from buffer";
>
> In addition to the informaton typo, should this read s/from buffer/for
> buffer/ ?
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> > +
> >       return nullptr;
> >  }
> >
>

Given the fixes,
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> --
> Regards,
>
> Laurent Pinchart
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel