[libcamera-devel] [PATCH v3 00/16] Support SensorTimestamp metadata

Jacopo Mondi jacopo at jmondi.org
Wed Apr 21 18:03:03 CEST 2021


The series keeps growing...

Rebased on Laurent's ControlList::merge(), with a test for the function added

One thing to notice: ControlList::merge() wants a ControlList &, while we
usually have a const ControlList & in pipeline handlers.

I've worked around it with a const_cast<> in callers, but providing a
ControlList::merge(const ControlList &) version which does the cast internally
might be (dangerous but) better.

Apart from that I collected the commens on v2 and added tags.

Thanks
  j

Jacopo Mondi (15):
  test: control_list: Check for Brightness presence
  test: control_list: Test ControlList::merge()
  libcamera: controls: Destage 'SensorTimestamp'
  libcamera: ipu3: Report sensor timestamp
  libcamera: uvc: Report sensor timestamp
  libcamera: rkisp1: Do not over-write metadata
  libcamera: rkisp1: Report sensor timestamp
  libcamera: simple: Report sensor timestamp
  libcamera: vimc: Report sensor timestamp
  libcamera: buffer: Re-work setRequest() documentation
  libcamera: raspberrypi: Do not over-write metadata
  libcamera: raspberry: Report sensor timestamp
  cam: Add option to print the Request metadata
  cam: Implement OptMetadata
  android: camera_device: Use controls::SensorTimestamp

Laurent Pinchart (1):
  libcamera: controls: Add a function to merge two control lists

 include/libcamera/controls.h                  |  2 +
 src/android/camera_device.cpp                 | 19 +++-----
 src/android/camera_device.h                   |  3 +-
 src/cam/capture.cpp                           | 15 ++++++-
 src/cam/capture.h                             |  1 +
 src/cam/main.cpp                              |  3 ++
 src/cam/main.h                                |  1 +
 src/libcamera/buffer.cpp                      |  5 ++-
 src/libcamera/control_ids.yaml                | 21 ++++++---
 src/libcamera/controls.cpp                    | 20 +++++++++
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++
 .../pipeline/raspberrypi/raspberrypi.cpp      | 21 ++++++++-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 11 ++++-
 src/libcamera/pipeline/simple/simple.cpp      | 12 ++++-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  3 ++
 src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++
 test/controls/control_list.cpp                | 45 ++++++++++++++++++-
 17 files changed, 164 insertions(+), 31 deletions(-)

--
2.31.1



More information about the libcamera-devel mailing list