[libcamera-devel] [PATCH v6 0/3] libcamera: V4L2Device: VLA removal

[Hirokazu Honda]

Hi Laurent, thanks for the patches.

They look good to me.

On Mon, Apr 26, 2021 at 9:12 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hello,
>
> This patch series is a part of the v5 of V4L2 device control
> improvements posted by Hiro. I've split the VLA removal from the rest of
> the series, in order to merge those fixes while continue the discussion
> on the rest of the rework.
>
> Patch 1/3 has seen the most extensive rework, as it was very intertwined
> with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.
> Hiro, could you please have a look ? If everything is fine to you I'll
> merge the series. We can then discuss the rest of the changes rebased on
> top.
>
> Hirokazu Honda (3):
>   libcamera: V4L2Device: Replace VLA with std::vector in getControls()
>   libcamera: V4L2Device: Replace VLA with std::vector in setControls()
>   libcamera: V4L2Device: Use Span in updateControls()
>
>  include/libcamera/internal/v4l2_device.h |  4 +-
>  src/libcamera/v4l2_device.cpp            | 73 +++++++++++-------------
>  2 files changed, 36 insertions(+), 41 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>