[libcamera-devel] [PATCH] ipa: rkisp1: Move the IPA to the ipa::rkisp1 namespace

[Kieran Bingham]

Hi JM,

On 26/04/2021 09:59, Jean-Michel Hautbois wrote:
> 
> 
> On 26/04/2021 09:08, Sebastian Fricke wrote:
>> Hey Laurent and Jean-Michel,
>>
>> On 26.04.2021 09:42, Laurent Pinchart wrote:
>>> Hi Jean-Michel,
>>>
>>> On Mon, Apr 26, 2021 at 08:01:11AM +0200, Jean-Michel Hautbois wrote:
>>>> On 26/04/2021 07:57, Laurent Pinchart wrote:
>>>>> On Mon, Apr 26, 2021 at 07:49:11AM +0200, Jean-Michel Hautbois wrote:
>>>>>> On 26/04/2021 00:03, Laurent Pinchart wrote:
>>>>>>> On Fri, Apr 23, 2021 at 10:02:15AM +0100, Kieran Bingham wrote:
>>>>>>>> On 23/04/2021 07:39, Jean-Michel Hautbois wrote:
>>>>>>>>> Simplify name-spacing of the RKISP1 components by placing it in
>>>> the
>>>>>>>>> ipa::rkisp1 namespace directly.
>>>>>>>>
>>>>>>>> Given that I did the same for the IPU3 - Perhaps I'm biased, but
>>>> I think
>>>>>>>> this is better ;-D
>>>>>>>>
>>>>>>>>> Signed-off-by: Jean-Michel Hautbois
>>>> <jeanmichel.hautbois at ideasonboard.com>
>>>>>>>>
>>>>>>>> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>>>>>>
>>>>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>>>>>>>
>>>>>>> We should consider renaming IPARkISP1Interface to Interface
>>>> though, and
>>>>>>> IPARkISP1 to... Implementation ?
>>>>>>
>>>>>> Thanks.
>>>>>> Do you mean having the following ?
>>>>>>
>>>>>> -class IPARkISP1 : public IPARkISP1Interface
>>>>>> +class Implementation : public Interface
>>>>>>
>>>>>> It would be the same for all IPAs then ?
>>>>>
>>>>> That's the idea, yes. It's just an idea though :-) It looks a bit...
>>>>> bare maybe ? But if we keep IPA and RkISP1 in the name of the classes,
>>>>> it defeats the purpose of namespaces a little bit.
>>>>
>>>> For reading ease couldn't we have:
>>>> class RkISP1Implementation: public RkISP1Interface
>>>>
>>>> That would keep the naming without the IPA :-).
>>>> It is "just" a mojom patching, right :-p ?
>>>
>>> Or
>>>
>>> class IPAImplementation : public IPAInterface
> 
> But there is already a base class IPAInterface in
> include/libcamera/ipa/ipa_interface.h !
> According to me, RkISP1Interface inherits from the IPAInterface right now...
> 
> Or did I miss something here... (I probably have)

Isn't it the namespacing?

I.e.

libcamera::ipa::IPAInterface

is a different class to

libcamera::ipa::rkisp1::IPAInterface


Thus the namespace specifies the ... specification of the interface ...

Regards
--
Kieran