[libcamera-devel] [RFC PATCH v2 02/12] android: Switch to FULL

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Thu, Apr 22, 2021 at 06:40:52PM +0900, Paul Elder wrote:
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 9336a027..76863877 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1258,7 +1258,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()
>  	staticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, &croppingType, 1);
>  
>  	/* Info static metadata. */
> -	uint8_t supportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;
> +	uint8_t supportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;

This should be conditioned by the capabilities of the camera. It's fine
for now to enable CTS in FULL mode, but will need to be fixed. Could you
please add at least a \todo comment ?

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  	staticMetadata_->addEntry(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,
>  				  &supportedHWLevel, 1);
>  

-- 
Regards,

Laurent Pinchart