[libcamera-devel] [PATCH v4 0/4] Raspberry Pi: handle sensors more flexibly
David Plowman
david.plowman at raspberrypi.com
Tue Apr 27 15:08:40 CEST 2021
Hi
Here's a version 4 of this patch set. The only difference over v3 is a
new penultimate patch that adds new V4L2 controls for informing the
sensor of the colour gains.
I've actually added a control for each of the 4 Bayer colour channels
even though I use only two of them. It feels like one of those things
where some sensor may eventually want the ones that I might have been
tempted to miss out, at which point why not just include them? Though
I still wonder if having both GREENR and GREENB is overkill, and just
GREEN would have sufficed. Any thoughts on that?
Once we're happy with the changes here I can apply them in the
Raspberry Pi Linux distribution, and then we can look to upstream them
too.
Thanks in advance
David
David Plowman (4):
ipa: raspberrypi: Make CamHelper exposure methods virtual
ipa: raspberrypi: Add CamHelper::ColourGainCode method
include: linux: Add V4L2_CID_NOTIFY_GAIN_XXX controls
ipa: raspberrypi: Update sensor's V4L2_CID_NOTIFY_GAIN_RED/BLUE
controls when present
include/libcamera/ipa/raspberrypi.mojom | 1 +
include/linux/v4l2-controls.h | 4 ++++
src/ipa/raspberrypi/cam_helper.cpp | 18 ++++++++++++++++++
src/ipa/raspberrypi/cam_helper.hpp | 8 +++++---
src/ipa/raspberrypi/raspberrypi.cpp | 13 +++++++++++++
.../pipeline/raspberrypi/raspberrypi.cpp | 10 ++++++++++
6 files changed, 51 insertions(+), 3 deletions(-)
--
2.20.1
More information about the libcamera-devel
mailing list