[libcamera-devel] [PATCH] android: camera_stream: Rectify internal header's #include path

Niklas Söderlund niklas.soderlund at ragnatech.se
Thu Apr 29 13:26:00 CEST 2021


Hi Umang,

Thanks for your work.

On 2021-04-29 16:27:41 +0530, Umang Jain wrote:
> libcamera internal headers are not installed system-wide. Hence, any
> inclusion of internal headers should be follow the #include directive
> form:
> 	#include "libcamera/internal/header.h"

This also needs fixing in generic_camera_buffer.cpp and 
post_processor.h.

> 
> This was not the case with buffer.h internal header. Fix it.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/android/camera_stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
> index f68fdd3a..34016722 100644
> --- a/src/android/camera_stream.h
> +++ b/src/android/camera_stream.h
> @@ -19,7 +19,7 @@
>  #include <libcamera/geometry.h>
>  #include <libcamera/pixel_format.h>
>  
> -#include <libcamera/internal/buffer.h>
> +#include "libcamera/internal/buffer.h"
>  
>  class CameraDevice;
>  class CameraMetadata;
> -- 
> 2.29.2
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list